[Webkit-unassigned] [Bug 36434] [chromium]WebKit side of adding search support to Pepper.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36434


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51538|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #9 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-03-24 13:58:15 PST ---
(From update of attachment 51538)
> Index: WebKit/chromium/public/WebNode.h

> +    // DEPRECATED! use toConstElement() instead

nit: "use toConst() instead"


> Index: WebKit/chromium/public/WebPluginDocument.h

> +    WebPluginDocument(const WebPluginDocument& e) : WebDocument(e) { }
> +
> +    WebPluginDocument& operator=(const WebPluginDocument& e)
> +    {
> +        WebNode::assign(e);
> +        return *this;
> +    }
> +    void assign(const WebPluginDocument& e) { WebNode::assign(e); }

nit: "e" stood for WebElement probably in the case you copied this
from.  how about using "d" for document instead?


R=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.