[Webkit-unassigned] [Bug 25645] SVG - overflow for big sized elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25645





--- Comment #11 from David Yonge-Mallo <davinci at chromium.org>  2010-03-24 13:45:08 PST ---
(In reply to comment #10)
> (From update of attachment 51467 [details])
> > 
> >  template <typename FloatType> static bool _parseNumber(const UChar*& ptr, const UChar* end, FloatType& number, bool skip)
> >  {
> > -    int integer, exponent;
> > -    FloatType decimal, frac;
> > +    int exponent;
> > +    FloatType integer, decimal, frac;
> 
> I'm not sure I agree with this. Why not use 'long long' for integer and
> exponent?

The test case in the patch actually overflows 'long long' as well, so it will
return the wrong result.

Also, I'm not sure that 'long long' for the exponent is realistic (even though
we should aim to handle anything).  Even for enormous numbers, the exponent is
relatively small (fits into an int).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.