[Webkit-unassigned] [Bug 36527] Need an ASSERT that's enabled in release builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36527





--- Comment #10 from Jeremy Orlow <jorlow at chromium.org>  2010-03-24 11:32:10 PST ---
(In reply to comment #8)
> FATAL_ERROR is a new name for CRASH, not a name for an assertion. The macro
> would not take an argument.

Ohhh.  I see.  Yeah, I guess FATAL_ERROR is a bit more clear than CRASH, but
honestly I'm not sure it's enough of an improvement to warrant a change.  But I
assume you do?


(In reply to comment #9)
> I think the note could be like the RefPtr one I wrote a while back. I'm not
> sure where the link to that is, but the key is the content; linking to it is
> easy.

I agree linking is easy, but if no one can find the link, what's the use?  :-)

To be honest, I wonder if a code comment above CRASH is the right thing to do
here.  I think a separate web page for PassRefPtr/RefPtr makes sense since it's
indexed by search engines and because it's pretty big for putting inside the
code (plus it's not clear whether it'd go in PassRefPtr or RefPtr.h) but I
don't think CRASH/FATAL_ERROR suffer from this problem.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.