[Webkit-unassigned] [Bug 36505] Generated run-in Content is Mistakenly Getting Deleted

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36505





--- Comment #2 from mitz at webkit.org  2010-03-24 08:44:51 PST ---
(From update of attachment 51456)
I am going to review the code change soon, but I already have a comment about
the test.

> +// Force a second, dynamic layout
> +setTimeout(function() {
> +    document.getElementById('inner').style.color = 'blue';
> +}, 0);

This is not a reliable (because without using LayoutTestController’s
waitUntilDone()/notifyDone() the test may end before the timer fires) nor
efficient way to do this. The standard way to force layout is to query a DOM
property that depends on layout. Tests commonly just include this statement:
    document.body.offsetTop;
which forces layout. Then you do your style change, then when the document is
done loading, it forces another layout, then the final render tree is dumped.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.