[Webkit-unassigned] [Bug 36436] QGraphicsWebView crash when calling setView on the QWebPage...

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36436


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51460|review?                     |review+
               Flag|                            |




--- Comment #12 from Simon Hausmann <hausmann at webkit.org>  2010-03-24 08:31:32 PST ---
(From update of attachment 51460)

> +    virtual bool isQWidgetClient() { return false; }

This should be const.


> +    d->unsetPageIfExists();
>      d->page = page;

The pattern seems to call this function and then set the page. Why not merge
both into one setPage() function,
that unsets the previous page and sets the new one (even if it's null)?

The rest of the patch looks good to me. I suggest to fix the const before
landing (all three occurences), I leave the setPage vs. unsetPageIfExists() up
to you :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.