[Webkit-unassigned] [Bug 36527] Need an ASSERT that's enabled in release builds
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 24 08:31:14 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=36527
--- Comment #3 from Jeremy Orlow <jorlow at chromium.org> 2010-03-24 08:31:13 PST ---
(In reply to comment #2)
> The major reason the expression goes inside the assert invocation is so that
> the entire expression can be compiled out.
>
> For the rare cases where we want assertions even in production code, I think
> it's good to have all the code outside any macro.
>
> We can give CRASH a better name to make it clearer how it should be used and
> maybe even add a message, but I'd prefer not to also have an ASSERT-style macro
> where the contents are always evaluated. Such things can be written as if
> statements. But since the Chrome project already has this, maybe you guys don't
> agree.
Normally I'd agree with you. I guess the main reason why having a macro seems
natural here is that I see it as a variant of ASSERT and ASSERT is a macro. I
suppose that's the only reason though. I don't feel super strongly, so if
others feel the same way, we can close this as WONTFIX.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list