[Webkit-unassigned] [Bug 36482] Regression(r55766): [Chromium] chromiumDataObject.hasData() reports true for an empty clipboard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36482


Roland Steiner <rolandsteiner at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51485|                            |review?
               Flag|                            |




--- Comment #8 from Roland Steiner <rolandsteiner at chromium.org>  2010-03-24 01:31:21 PST ---
Created an attachment (id=51485)
 --> (https://bugs.webkit.org/attachment.cgi?id=51485)
patch - check whether new URL is valid/empty, fix 2 incorrect usages in
ClipboardChromium

> Aha, found it.  ChromiumClipboard is a friend class of ChromiumDataObject and
> it sets url directly in a lot of places (declareAndWriteDragImage, writeURL,
> etc).  I guess they should no longer be friends?  That causes this check to be
> missed most of the time.

The friend clause was actually by design, so that ClipboardChromium (and only
ClipboardChromium) can populate a ChromiumDataObject without too much fuss. But
you're right, the last 2 places (declareAndWriteDragImage, writeURL) are
incorrect. That's actually a bug from an earlier patch, but I can just as well
fix it here.

Uploaded new patch that fixes the incorrect usage.

(Aside: Note that this code may well be quite short-lived once Daniel Cheng
finishes his general MIME-support refactoring.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.