[Webkit-unassigned] [Bug 36487] Refactoring: HTMLFormControlElement should not have redundant null check

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36487





--- Comment #5 from MORITA Hajime <morrita at google.com>  2010-03-23 22:21:11 PST ---
Thank you for reviewing!

> The changes to HTMLCanvasElement::convertLogicalToDevice and
> HTMLCanvasElement::convertLogicalToDevice are different though. Those are
> adding a null check of Page*. Presumably, this is a bug fix. Before, there
> would be a crash if the page was zero. That means we need to construct a test
> case to demonstrate that crash, and that the crash is fixed.
Agreed. But I could not figure out the test case for crash,
so I remove the change on HTMLCanvasElement.

@ap
Thank you reviewing too.
You are right. I did attempt to simplify the null-check code, 
but It actually introduced a redundant null check at runtime.

Regards.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.