[Webkit-unassigned] [Bug 36489] [DRT/Chromium] Add TestNavigationController and TestWebWorker
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 23 20:50:39 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=36489
--- Comment #4 from TAMURA, Kent <tkent at chromium.org> 2010-03-23 20:50:39 PST ---
(In reply to comment #2)
> (From update of attachment 51415 [details])
> Why do we need TestNavigationController in its full glory in DRT? Most of its
> work is focused around providing a simple browser, which we don't need here.
We need it to produce the output of layoutTestControler.dumpBackForwardList.
> > +TestNavigationEntry::TestNavigationEntry(
> > + int pageID, const GURL& url, const WebString& title, const WebString& targetFrame)
>
> Can we use WebURL here -- or at least put a FIXME?
Replaced GURL with WebURL.
> > +#include "base/basictypes.h"
> > +#include "base/linked_ptr.h"
> > +#include "base/ref_counted.h"
>
> It would be good to use WTF types here, but a FIXME should suffice for now.
Removed ref_counted.h, which was not used in this file.
I think no WTF alternative for linked_ptr.h.
> > +#define TestWebWorker_h
> > +
> > +#include "base/basictypes.h"
>
> No need for this here.
Right. Removed.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list