[Webkit-unassigned] [Bug 36484] [chromium] correctly handle move drag operations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36484


Jian Li <jianli at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jianli at chromium.org




--- Comment #3 from Jian Li <jianli at chromium.org>  2010-03-23 18:54:07 PST ---
> --- a/WebKit/chromium/src/WebViewImpl.cpp
> +++ b/WebKit/chromium/src/WebViewImpl.cpp

> -unsigned long WebViewImpl::createUniqueIdentifierForRequest() {
> +WebDragOperation WebViewImpl::dragTargetDragging(WebCore::DragData* dragData, bool isEntering)
> +{
I think the creation of DragData could also be shared in this function.
    DragData dragData(
        m_currentDragData.get(),
        clientPoint,
        screenPoint,
        static_cast<DragOperation>(operationsAllowed));

> --- a/WebKit/chromium/src/WebViewImpl.h
> +++ b/WebKit/chromium/src/WebViewImpl.h

> +    // Consolidate some common code between starting a drag over a target and
> +    // updating a drag over a target.  If we're starting a drag, |isEntering|
> +    // should be true.
> +    WebDragOperation dragTargetDragging(WebCore::DragData*, bool isEntering);
Probably it might be better to call it as dragTargetDragEnterOrOver.
In addition, since WebKit does not have line length, we do not need to split
the long comment into 3 tidy lines.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.