[Webkit-unassigned] [Bug 36482] Regression(r55766): [Chromium] chromiumDataObject.hasData() reports true for an empty clipboard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36482





--- Comment #3 from Tony Chang (Google) <tony at chromium.org>  2010-03-23 17:04:13 PST ---
(From update of attachment 51403)
> +        No new tests. (simple code change)

Is it possible to write a layout test for this?  Would be nice to make sure we
don't regress in the future.

> +void ChromiumDataObject::setURL(const KURL& newURL)
> +{
> +    ASSERT(newURL.isValid() || newURL.isEmpty());

Do we really want to assert here?  Can't javascript try to set an invalid URL? 
We shouldn't assert in that case.

> +    uriList.clear();
> +    if (newURL.isValid()) {

What about the constructor?  It doesn't go through this code path.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.