[Webkit-unassigned] [Bug 36474] Add support for revision -> build lookup in buildbot.py and layout test result parsing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36474





--- Comment #5 from Eric Seidel <eric at webkit.org>  2010-03-23 14:22:07 PST ---
(In reply to comment #4)
> + _fetch_layout_test_results
> 
> I'd prefer if all control paths had explicit returns.

Ludite! :)  I think it's actually more readable to not add the "return None"
since that's implied in python.

> + _parse_twisted_file_row
> 
> This twisted stuff should be in a separate file.  It's not specific to
> buildbot.

Agreed.  The functions started out as specific to this task, but I realized
they could be made general.  i'm not sure where we'd put any other "twisted"
stuff, but I named them so that they would be easy to recognize as general.

> - _longest_builder_name
> 
> Why did we get rid of this function?  It seemed helpful to document what that
> complex line is doing.

I had to copy the code.  I realized it was a realatively simple one-liner and
didn't have any good place to put that funciton, so I just inlined it in both
places.

I think I'm just gonna land as is, but I'm happy to make further changes upon
further discussion with you.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.