[Webkit-unassigned] [Bug 36487] Refactoring: HTMLFormControlElement should not have redundant null check

Tue Mar 23 13:57:02 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=36487

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51413|review?                     |review-
               Flag|                            |

--- Comment #3 from Darin Adler <darin at apple.com>  2010-03-23 13:57:02 PST ---
(From update of attachment 51413)
The changes to HTMLFormControlElement::dispatchFocusEvent and
HTMLFormControlElement::dispatchBlurEvent are OK. Not a great improvement, but
nice to use the Document::page helper function to save a little code.

The changes to HTMLCanvasElement::convertLogicalToDevice and
HTMLCanvasElement::convertLogicalToDevice are different though. Those are
adding a null check of Page*. Presumably, this is a bug fix. Before, there
would be a crash if the page was zero. That means we need to construct a test
case to demonstrate that crash, and that the crash is fixed.

review-

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.