[Webkit-unassigned] [Bug 36474] Add support for revision -> build lookup in buildbot.py and layout test result parsing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36474





--- Comment #4 from Adam Barth <abarth at webkit.org>  2010-03-23 13:43:31 PST ---
We need to abstract out the calls to urllib2.urlopen.  We keep using the same
idiom to surround them.  We could include the 404 handling and caching as
optional parameters.

+ _fetch_layout_test_results

I'd prefer if all control paths had explicit returns.

+ _parse_twisted_file_row

This twisted stuff should be in a separate file.  It's not specific to
buildbot.

- _longest_builder_name

Why did we get rid of this function?  It seemed helpful to document what that
complex line is doing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.