[Webkit-unassigned] [Bug 36315] Remove obsolete Geolocation::m_currentPosition

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36315





--- Comment #3 from Steve Block <steveblock at google.com>  2010-03-23 12:06:21 PST ---
(From update of attachment 51091)
+        Remove obsolete Geolocation::m_currentPosition
+        (follow up on https://bugs.webkit.org/show_bug.cgi?id=30676)
tabs

Looks good to me otherwise. To further clarify the code, we could remove the
Geoposition argument from positionChanged() and hence setPosition(). Instead,
positionChanged() would just call m_service->lastPosition() directly. This
would also bring the client-based code path in line with the existing code
path. 

Also, I think that in a future change we should remove m_lastPosition, as it
serves no purpose as far as I can see.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.