[Webkit-unassigned] [Bug 34912] audio engine: add ReverbConvolver class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34912





--- Comment #21 from Jeremy Orlow <jorlow at chromium.org>  2010-03-23 10:32:19 PST ---
(In reply to comment #19)
> Hi Jeremy, I've addressed most of your comments.  Here are my comments about
> the others:
> 
> >Always use ___Ptr's as member and automatic/local variables.  Use Pass___Ptr's
> >as method parameters and return values.  You might want to re-read the
> >PassRefPtr doc (just google that word) if you don't understand why.
> 
> I've found that this can work with RefPtr, but not with OwnPtr (won't compile).
>  It looks like in the case of OwnPtr, it's not reference counted and you can't
> assign from one OwnPtr to another.  The current code does the right thing, but
> another option is to just forget the PassOwnPtr and use a straight pointer as
> the local variable.  It gets appended to a Vector<OwnPtr<> > so the memory
> management is handled.

The point of the OwnPtr is that it'll get deleted if you go out of scope.  I
don't know what you're doing wrong here, but there are a LOT of examples in the
code of how to do this properly.  Make sure you have PassOwnPtr.h included in
the file.  It should know how to convert stuff from an OwnPtr to a PassOwnPtr.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.