[Webkit-unassigned] [Bug 34930] Implement interactive validation for forms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34930





--- Comment #7 from TAMURA, Kent <tkent at chromium.org>  2010-03-23 05:37:23 PST ---
Thank you for reviewing!

(In reply to comment #4)
> + contorol
> ^^ Typo

Fixed.

> + unsigned i
> We usually use int for these sorts of loops.

I don't agree with it. 'int' makes a warning about signed vs. unsigned in this
case, and the number of "for (unsigned" is greater than "for (size_t" in
WebCore.

> I'm also not super excited about adding a bunch of random arguments to these
> functions.  Can we abstract this better somehow? 

I have no good idea.  As for the additional parameter of checkValidity(), it
was planed when checkValidity() was added.  The proposed patch for the original
checkValidity() had the parameter for the preparation of this change, but it
was removed during the code review.

> Also, the loop in
> HTMLFormElement::prepareSubmit is pretty complicated, mostly just so we can
> print more messages to the console.  Can we simplify this somehow?

I improved it a little.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.