[Webkit-unassigned] [Bug 35072] [Mac] Move Icon::iconForFiles() code to WebChromeClient::iconForFiles().

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 23 04:46:46 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=35072





--- Comment #12 from TAMURA, Kent <tkent at chromium.org>  2010-03-23 04:46:45 PST ---
> This function name is not good. The function doesn't return an icon, so it
> shouldn't be named "icon". I suggest the name chooseIconForFiles.

Done.

> The argument types on this function may also be wrong. A function should only
> take a PassRefPtr if it's taking ownership of an object. This function does not
> take ownership of the FileChooser object.

Chromium implementation will need to take ownership because of asynchronous
loading.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list