[Webkit-unassigned] [Bug 35607] Allow building smoothly on win32 and win64 using GCC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35607


vanboxem.ruben at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vanboxem.ruben at gmail.com




--- Comment #28 from vanboxem.ruben at gmail.com  2010-03-23 03:12:20 PST ---
Hi, I've been working on the same problem in bug
https://bugs.webkit.org/show_bug.cgi?id=34922 and have some remarks to this
patch:
I'll be talking about mingw64 (=mingw-w64/w32) and mingw.org (=old MinGW)

 - OS(WINDOWS) && CPU(X86_64) is not garanteed to be only mingw-w64 in the
future. Mingw.org could make a 64-bit compiler and not implement several
functions provided by mingw64.
 - !defined(__MINGW64_VERSION_MAJOR) is against WebKit style, you should use a
custom COMPILER define (like I did in my patch).
 - You missed a lot of code by the way, including stuff in JavaScriptCore.

I find it surprising that this patch was accepted with above issues present.
Please reconsider. If you need it, I can upload my patch here, adapted to the
modifications made here (mine dates from before this patch, only a problem in
the JavaScriptCore portion of the code.

Thanks

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.