[Webkit-unassigned] [Bug 36477] webkit-patch reads wrong bug url from unified diff context

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36477





--- Comment #4 from MORITA Hajime <morrita at google.com>  2010-03-22 23:09:14 PST ---
Thank you for reviewing quickly!

(In reply to comment #2)
> This is the wrong fix.  In this case you want to just use the code for pulling
> the bug from the ChangeLogEntry instead of the diff.  This proposed change
> would still wrongly grab bug urls added in other parts of the diff besides the
> ChangeLog.
Agreed.

> I recently added a ChangeLogEntry class which exposes a bug_id() method which
> should fix this case.
I couldn't find bug_id() on ChangeLogEntry. It looks not landed yet.
Would you tell me which bug contains that?
I'll watch it and retry this after its landing.

BTW, Bug 33471 and Bug 33197 looks similar. But I'm not sure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.