[Webkit-unassigned] [Bug 36477] webkit-patch reads wrong bug url from unified diff context

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 22 22:47:49 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36477


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51393|review?                     |review-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2010-03-22 22:47:49 PST ---
(From update of attachment 51393)
This is the wrong fix.  In this case you want to just use the code for pulling
the bug from the ChangeLogEntry instead of the diff.  This proposed change
would still wrongly grab bug urls added in other parts of the diff besides the
ChangeLog.

I recently added a ChangeLogEntry class which exposes a bug_id() method which
should fix this case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list