[Webkit-unassigned] [Bug 36465] window.Document !== window.XMLDocument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36465


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51368|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2010-03-22 16:38:39 PST ---
(From update of attachment 51368)
> -    static PassRefPtr<Document> createDocument(Frame*);
> +    static PassRefPtr<XMLDocument> createDocument(Frame*);

I think we should get rid of DOMImplementation::createDocument and
DOMImplementation::createHTMLDocument. I can't find any callers of either
function.

> +    static PassRefPtr<Document> createXHTML(Frame* frame)
> +    {
> +        return adoptRef(new XMLDocument(frame, true));
> +    }

Return type here should be PassRefPtr<XMLDocument>.

> +    XMLDocument(Frame* frame, bool isXHTML);

This should be private; it is only called from the static member functions
above.

> +    virtual ~XMLDocument();

This isn't needed at all. We should leave it out.

> --- a/WebCore/xml/XMLHttpRequest.cpp
> +++ b/WebCore/xml/XMLHttpRequest.cpp
> @@ -41,6 +41,7 @@
>  #include "Settings.h"
>  #include "TextResourceDecoder.h"
>  #include "ThreadableLoader.h"
> +#include "XMLDocument.h"

We should also remove the include of "Document.h".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.