[Webkit-unassigned] [Bug 36395] [Qt] Patch to add support for Content-Disposition...

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36395





--- Comment #20 from adawit at kde.org  2010-03-22 15:43:19 PST ---
(In reply to comment #17)
> (From update of attachment 51199 [details])
> I prefer this approach, but instead of duplicating the code from
> WebKit/chromium/src/FrameLoaderClientImpl.cpp it should be moved into a common
> method in WebCore, maybe WebCore/platform/network/HTTPParser.*.
> 
> Also this patch is missing a ChangeLog.

The code that deals with the detecting "content-disposition" can indeed be
moved into a common location instead of being duplicated. I did it this way
because a.) I did not know where to factor the code out to and more importantly
I did not think it would be okay to modify the codebase of another client which
we would have to if we factor the code out. 

Anyhow, I will move the code out to a common location
WebCore/platform/network/HTTPParsers.* as you suggest and provide a new patch
based on that. I will also provide a ChangeLog entry for my changes...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.