[Webkit-unassigned] [Bug 34912] audio engine: add ReverbConvolver class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34912





--- Comment #19 from Chris Rogers <crogers at google.com>  2010-03-22 14:45:56 PST ---
Hi Jeremy, I've addressed most of your comments.  Here are my comments about
the others:

>Always use ___Ptr's as member and automatic/local variables.  Use Pass___Ptr's
>as method parameters and return values.  You might want to re-read the
>PassRefPtr doc (just google that word) if you don't understand why.

I've found that this can work with RefPtr, but not with OwnPtr (won't compile).
 It looks like in the case of OwnPtr, it's not reference counted and you can't
assign from one OwnPtr to another.  The current code does the right thing, but
another option is to just forget the PassOwnPtr and use a straight pointer as
the local variable.  It gets appended to a Vector<OwnPtr<> > so the memory
management is handled.

> Forward declare rather than including since it's only an OwnPtr.
In general I always try to follow that principle.  I was able to get rid of
#include "FFTConvolver.h"
but then had to add in
#include "FFTFrame.h"
since I'm using object composition.
I was able to get rid of OwnPtr.h and PassOwnPtr.h though - thanks...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.