[Webkit-unassigned] [Bug 36394] Include git commits in the diff for webkit-patch upload/land.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36394





--- Comment #7 from Ojan Vafai <ojan at chromium.org>  2010-03-22 12:01:17 PST ---
(In reply to comment #4)
> Note that check-webkit-style also uses create_patch() when invoked without
> passing paths.  What implications will this change have?

This means that local commits that are not in SVN will also be included in the
check-webkit-style call. That seems correct to me.

> Also, should the same logic be applied to create_patch_from_local_commit() and
> create_patch_since_local_commit() for consistency?

I'm not sure. These seem correct to create a patch just for a single commit...I
think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.