[Webkit-unassigned] [Bug 36438] Use "-f" option instead of "--force" for git rm.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 22 10:22:29 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36438


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51274|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2010-03-22 10:22:29 PST ---
(From update of attachment 51274)
Lame.  We should document what minimum version of git scm.py and this file are
expected to support.

This change also needs a comment explaining why it's -f so that someone doesn't
later change it back to --force.

Can we unit test this?  I guess not easily given the current design of the perl
scripts.

r- mostly because this needs a comment/further documentation in the file, and I
don't believe this is a full fix (does scm.py need a similar fix?)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list