[Webkit-unassigned] [Bug 35783] [GStreamer] Use ImageBuffer API to do painting
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 22 09:01:39 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=35783
--- Comment #18 from Philippe Normand <pnormand at igalia.com> 2010-03-22 09:01:39 PST ---
(In reply to comment #17)
> > +
> > + cairo_format_t cairoFormat;
> > + if (format == GST_VIDEO_FORMAT_ARGB || format == GST_VIDEO_FORMAT_BGRA)
> > + cairoFormat = CAIRO_FORMAT_ARGB32;
> > + else
> > + cairoFormat = CAIRO_FORMAT_RGB24;
> > +
> In the previous review I recommended asserting the format is
> GST_VIDEO_FORMAT_RGB before assigning CAIRO_FORMAT_RGB24. I suspect Cairo will
> support other pixel formats in the future, if so someone will want to optimize
> and not always convert to RGB. Do you disagree?
>
Yes ;) It can be sparse RGB too, like GST_VIDEO_FORMAT_BGRx or
GST_VIDEO_CAPS_xRGB depending on endian-ness. CAIRO_FORMAT_RGB24 is little/big
endian dependant as mentionned in the VideoSinkGStreamer.cpp file, where the
sinktemplate of the sink is defined.
Should I really assert anyway?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list