[Webkit-unassigned] [Bug 16662] CSS3: Implement calc()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16662


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48752|review?                     |review-
               Flag|                            |




--- Comment #22 from Adam Barth <abarth at webkit.org>  2010-03-22 08:39:24 PST ---
(From update of attachment 48752)
Holy cow.  This sounds pretty cool, but I'm sorry that we aren't able to accept
this patch at this time.  This patch has been sitting in the review queue for a
month and no one seems willing or able to review the patch.  Instead of just
letting the patch linger here forever, I'm marking the patch r- (with the lame
excuse of a style violation).

My guess is the best way to proceed here is to
(1) contact a reviewer who knows this part of the code,
(2) make sure we want to implement this feature at this time,
(3) get some feedback your approach, and
(4) have the reviewer review your code.

The patch, as it stands, raise the following questions for me:
(A) Are we sure we want to abuse the higher order bits of Length to track this
extra state information?  That doesn't seem to scale well to future code and
non 32-bit architectures.
(B) Why are we implementing this as -webkit-calc?  If the spec is ready to be
implemented, it seems like we should just implement as calc and save the web
the trouble of dealing with our vendor-specific non-sense.
(C) Is there a CSS3 conformance test in this area we can use to test our
implementation?

I apologize for the delay in reviewing your patch, but it's important to
communicate with other members of the project before going off and implementing
features.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.