[Webkit-unassigned] [Bug 34930] Implement interactive validation for forms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34930


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48728|review?                     |review-
               Flag|                            |




--- Comment #4 from Adam Barth <abarth at webkit.org>  2010-03-22 08:26:06 PST ---
(From update of attachment 48728)
This looks reasonable, but you need to spin up a new patch because this break
the Chromium build and there are few nits:

+ contorol
^^ Typo

+ unsigned i

We usually use int for these sorts of loops.

+ message.replace("%name", unhandled->name());

Please use String::format()

I'm also not super excited about adding a bunch of random arguments to these
functions.  Can we abstract this better somehow?  Also, the loop in
HTMLFormElement::prepareSubmit is pretty complicated, mostly just so we can
print more messages to the console.  Can we simplify this somehow?

Sorry for the delay in reviewing your patch (and the lame review).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.