[Webkit-unassigned] [Bug 34912] audio engine: add ReverbConvolver class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34912





--- Comment #14 from Jeremy Orlow <jorlow at chromium.org>  2010-03-22 05:22:54 PST ---
> I *did* remove the virtual, but I tend to *always* use virtual for destructors
> unless I know for a fact that I need the object to occupy an exact number of
> bytes (to overlay a struct, for example) or if there are other clear
> performance reasons not to.  The reason is that it's very easy to create
> difficult to track down bugs if you later sub-class and forget the virtual.

Understood, but in general we try hard to avoid making things virtual in
WebKit.  I also think it's a good habit to always double check whenever you
subclass something that the parent has a virtual destructor.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.