[Webkit-unassigned] [Bug 36395] [Qt] Patch to add support for Content-Disposition...

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 21 20:17:31 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36395





--- Comment #10 from adawit at kde.org  2010-03-21 20:17:31 PST ---
(In reply to comment #8)
> > Where does one mark the patches with the review flag ? Find the changelog file
> > though ; so I will go ahead and provide an patch that updates that as well...
> 
> Click on "details" next to your patch. You can also do it when you attach a new
> attachment.
> 
> Please generate ChangeLog using WebKitTools/Script/prepare-ChangeLog

Cannot use this at all since I am working off of a weekly snapshot and not a
git-clone of the qtwebkit respository. 

> Also, always check coding style using WebKitTools/Script/check-webkit-style

Did this and fixed only a single problem sort of related to my patch. However,
my changes seem to be in files that the script deems exempt from such checks. I
am talking about the qwebpage.* files specifically.

> That should get you going :-) Great patch btw!

Thanks for both ;)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list