[Webkit-unassigned] [Bug 36373] [Qt] Don't construct a QLineEdit every time when painting a text field

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36373





--- Comment #6 from Jakub Wieczorek <jwieczorek at webkit.org>  2010-03-21 16:37:06 PST ---
(In reply to comment #5)
> (In reply to comment #3)
> > > Instead of creating a global QLineEdit that runs the risk of being destructed
> > > after the QApplication destructor, how about assocating it with the
> > > RenderTheme? Then it would be destroyed when the page dies.
> > 
> > With this patch, QLineEdit would not be destructed as such -
> > DEFINE_STATIC_LOCAL allocates an object on the heap so the destructor would not
> > be called at the exit.
> 
> True true, but that's evil, too, isn't it? :)

Right. :)

Another option would be to make the QApplication instance the parent of this
object. This way we could avoid having one QLineEdit per page and could keep up
with the style change. If that sounds reasonable, I'll try this tomorrow,
otherwise I'll pick either of the ideas suggested by you.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.