[Webkit-unassigned] [Bug 36394] Include git commits in the diff for webkit-patch upload

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 21 14:40:34 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36394


Chris Jerdonek <cjerdonek at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cjerdonek at webkit.org,
                   |                            |hamaji at chromium.org,
                   |                            |levin at chromium.org




--- Comment #4 from Chris Jerdonek <cjerdonek at webkit.org>  2010-03-21 14:40:33 PST ---
Note that check-webkit-style also uses create_patch() when invoked without
passing paths.  What implications will this change have?

Also, should the same logic be applied to create_patch_from_local_commit() and
create_patch_since_local_commit() for consistency?

Might we want to create a new method instead?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list