[Webkit-unassigned] [Bug 36419] A backslash in EUC-JP becomes to a yen sign when it is copied

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36419





--- Comment #2 from Shinichiro Hamaji <hamaji at chromium.org>  2010-03-20 15:01:35 PST ---
As I wrote in Bug 24906, I'd like to fix this issue first.

This patch adds a parameter isForCopying into TextIterator and plainText uses
this version. I examined how plainText is used and if I understand correctly,
it is used by copying, spell checker, and transpose. I think our transcoding
doesn't affect the spell checker. Copying and transpose are covered by the
layout tests in my patch. Note that this patch fixes the issue of transpose as
well as copying. Before this patch, transposing "\\" yields "<yen><yen>".

I'll reply comments in Bug 24906 related to this issue.

> I don't understand the meaning here. What is a "non-display string"? A display
> string is a string intended for display to the end user. But "non-display"
> doesn't tell me anything.

I'm using textForCopying in this patch. It might not be the best name as this
will be used by a few other ways such as spell checker and transpose. I hope
this naming makes more sense because the main purpose of having this function
is copying.

> Does searching work correctly with this patch, so that a yen sign as visible on
> a web page can always be found by searching for a yen sign? I think it should
> work, but nothing beats actual testing.

As I wrote in Bug 24906, my patch in Bug 24906 broke searching, but this patch
won't. Thanks again for this catch.

> Do these tests pass in IE?

Yes, actually they are doing nothing, but the backslash in their font is the
yen sign.

> 2. In the text-transform + transcoding case, you just fall back on using the (transcoded) text() as the nonDisplayString(). Perhaps in this case you nonDisplayString() could apply the transform on the fly to the original string (so it will return a transformed, yet not transcoded, string).

Nice suggestion! Now my patch is doing on the fly transformation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.