[Webkit-unassigned] [Bug 36391] Potential for infinite recursion in SharedBuffer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36391





--- Comment #4 from Andy Estes <aestes at apple.com>  2010-03-19 19:16:54 PST ---
(In reply to comment #3)
> Hm... so in 2), if we
> 
> if (m_cfData) {
>  CFDataRef cfData(m_cfData);
>  m_cfData = 0;
>  append(cfData...);
> }
> 
> Will this solve the problem and is it a good way?

I think that would work.  I don't think you need to wrap the block with 'if
(m_cfData) {}' since maybeTransferPlatformData() returns early if m_cfData is
null.  Also, you'll either need to manually CFRetain() cfData before nulling
out m_cfData (or wrap your new CFDataRef in a RetainPtr, like we do with
m_cfData).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.