[Webkit-unassigned] [Bug 36196] REGRESSION(r52795): Cannot open complex webarchive files in Safari due to WebKit regression.

Fri Mar 19 14:21:00 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=36196

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51185|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |

--- Comment #14 from Darin Adler <darin at apple.com>  2010-03-19 14:21:00 PST ---
(From update of attachment 51185)
> Property changes on: WebCore/manual-tests/WebKitSite.webarchive
> ___________________________________________________________________
> Added: svn:executable
>    + *

To avoid problems with newlines this needs to have its MIME type set to a
binary type. Also, it should not have its executable bit set.

> +    // Internal data in SharedBuffer can be segmented.  We need to get the contiguous
> +    // buffer.

Comment should be on a single line, and have one space after the period.

r=me, but commit-queue- because we can't land the archive without the MIME type

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.