[Webkit-unassigned] [Bug 36201] hashchange event should be dispatched asynchronously

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36201





--- Comment #7 from Brady Eidson <beidson at apple.com>  2010-03-19 09:05:30 PST ---

> > 
> > > -    m_document->dispatchWindowEvent(PageTransitionEvent::create(eventNames().pageshowEvent, true), m_document);
> > > +    m_document->schedulePageshowEvent(true);
> > 
> > Boolean arguments where we pass constnat valuesstink. And what in the world is
> > "persisted"?
> 
> "persisted" is the official name of the field in the PageTransitionEvent that
> tells you whether this is a fresh page load or a page cache load, and it is
> defined to be a bool.  In this same patch I also call
> schedulePageShowEvent(false).
> 
> I'll make an enum for this for clarities sake, anyways.
> 

After digging in to this one, the PageTransitionEvent itself is too hard-wired
into using this bool, and has to remain as such for the purposes of the
DOM/IDL/etc.

I'm adding an enum to Document.h specifically for the Pageshow event helper
that will keep clarity there.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.