[Webkit-unassigned] [Bug 36259] <input type=range> does not validate correctly without a renderer and the tests are incorrect
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 18 18:53:47 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=36259
--- Comment #17 from TAMURA, Kent <tkent at chromium.org> 2010-03-18 18:53:46 PST ---
(In reply to comment #13)
> Created an attachment (id=51118)
--> (https://bugs.webkit.org/attachment.cgi?id=51118) [details]
> [PATCH] Part 2 - Added ASSERTs, Fixed Style Issue in Part 1
>
> Although I updated the tests to say that Range doesn't overflow / underflow, I
> still left the code in the path where it checks for an overflow / underflow. I
> moved RANGE out to the automatically false case, but I also put in an ASSERT
> just in case. This also updates some comments and fixes some style issues.
I recommend you post one patch per one bug. Our commit-queue doesn't work well
with multiple patches in one bug, and having review comments for multiple
patches in one bug is confusing.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list