[Webkit-unassigned] [Bug 36006] Multiselect popups - rendering

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36006





--- Comment #17 from Dave Hyatt <hyatt at apple.com>  2010-03-18 12:25:28 PST ---
(From update of attachment 51067)
> #if PLATFORM(QT) && ENABLE(TOUCHABLE_SELECTORS)

Don't include the Qt platform ifdef.  That should not be necessary.  Just use
ENABLE(TOUCHABLE_SELECTORS) by itself.  The point of ENABLE is to let you
define it on the platforms that use it and then platform ifdef gets hidden in
the cross-platform code.

I don't like the term "TOUCHABLE_SELECTORS" since it's not clear that we're
talking about multiple select boxes.  Really this feature is about collapsing
list boxes in the page and using an external popup to make your choices.

I think NO_LISTBOX_RENDERING would be more clear, as per your suggestion on
IRC.

The rest of the patch looks fine to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.