[Webkit-unassigned] [Bug 36308] [EFL] Add EFL-specific code to Icon.h, IntRect.h, FloatRect.h and IntPoint.h.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 18 11:08:30 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36308


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-03-18 11:08:31 PST ---
Attachment 51056 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/graphics/IntPoint.h:60:  Evas_Point is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/IntPoint.h:136:  Evas_Point is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/IntRect.h:160:  Eina_Rectangle is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/graphics/FloatRect.h:154:  Eina_Rectangle is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list