[Webkit-unassigned] [Bug 36177] Multiselect Popup - Listbox click simulation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36177


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51034|review?                     |review+
               Flag|                            |




--- Comment #23 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-03-18 10:19:44 PST ---
(From update of attachment 51034)

> +    virtual void listBoxSelectItem(int listIndex, bool allowMultiplySelections,
> +                           bool shift, bool fireOnChangeNow = true) = 0;

Please make this one line.

> +void HTMLSelectElement::listBoxSelectItem(int listIndex, bool allowMultiplySelections,
> +                                          bool shift, bool fireOnChangeNow)

here as well.

>  
> +    void listBoxSelectItem(int listIndex, bool allowMultiplySelections,
> +                           bool shift, bool fireOnChangeNow = true);

and here.

Apart from that LGTM.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.