[Webkit-unassigned] [Bug 20011] Printing test results differ between machines, we should use ImageDiff instead

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 18 02:38:34 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=20011





--- Comment #1 from Shinichiro Hamaji <hamaji at chromium.org>  2010-03-18 02:38:34 PST ---
Hi Eric, (of course, comments from other people are also welcomed! :)

Though I added two functions into layoutTestController so we can test some of
paged media related stuff, we still think we eventually need a way to dump
whole pages as a image. For example, even if we implement margin boxes, our
current test harness provides no way to test it.

So, I'm thinking about the best way to provide a way to dump all pages. I'm not
sure if dumping PDFs is the best as it would require some amount of efforts to
make it portable among ports. I'm considering to create printToPNG, which would
dump all pages into a PNG. With this approach, I think we can reuse fairly
amount of existing code (I don't look at code closely yet, but
PrintContext::spoolPage and PixelDumpSupport seem to do most tricks). One of
good points of PDF would be that boundaries of pages are very clear. I think we
can easily add some lines like <hr> into the PNG image as the signs of page
boundaries, so this won't be a serious lowlight of PNG approach.

If this plan makes sense, I'd like to start implementing it. Any suggestions
will be welcomed!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list