[Webkit-unassigned] [Bug 36257] REGRESSION: svn-apply does not handle overlapping diffs?

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36257





--- Comment #4 from Chris Jerdonek <cjerdonek at webkit.org>  2010-03-18 00:16:20 PST ---
(In reply to comment #3)
> fixChangeLogPatch expects each line to have at least one character.  I don't
> expect this to be an issue in practice since git diff, etc do this.  So this
> can be fixed by adding the leading space to the test cases, or better yet,
> making fixChangeLogPatch more lenient.

On second thought, I'm not sure that fixChangeLogPatch should be made more
lenient in this way.  It might be better if it simply errors out with a message
since the diff is ill-formatted.  Right now it returns the patch unchanged.

This is actually a FIXME in VCSUtils.pm:

        # FIXME: Handle errors differently from ChangeLog files that
        # are okay but should not be altered. That way we can find out
        # if improvements to the script ever become necessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.