[Webkit-unassigned] [Bug 36259] <input type=range> does not validate correctly without a renderer and the tests are incorrect

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 17 19:16:00 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36259


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joepeck at webkit.org




--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org>  2010-03-17 19:16:00 PST ---
(In reply to comment #4)
> > +        Part 1: Refactoring the SliderRange struct out of rendering/RenderSlider
> > +        into a more appropriate place. Changed the named to StepRange.
> 
> Would you explain what will be done in further patches please?

(In reply to comment #4)
> > +        Part 1: Refactoring the SliderRange struct out of rendering/RenderSlider
> > +        into a more appropriate place. Changed the named to StepRange.

Yes, I am going to start using StepRange inside HTMLInputElement to validate
<input type=range> values instead of with the renderer. I guess this could have
gone directly into HTMLInputElement, but I figured it would be generic and more
manageable as a separate file. I may make small changes to the  StepRange
struct which are much easier to notice in a separate patch instead of at the
same time as a move.

> > +        * WebCore.xcodeproj/project.pbxproj: Added new files.
> 
> Please change other build files.

Whoops! Thanks for the reminder.


Kent TAMURA, I see you have done a lot with validation in the past. Would you
agree that with the current spec rangeOverflow, rangeUnderflow, and
stepMismatch should never be true with an <input type=range>? That seems to be
where I am heading (removing the range specific tests completely). The spec has
a lot of "must"s which are "may" in the date / time inputs you worked on.

> When the element is suffering from an underflow, the user agent must set the element's value to a valid floating point number that represents the minimum.

> When the element is suffering from an overflow, if the maximum is not less than the minimum, the user agent must set the element's value to a valid floating point number that represents the maximum.

> When the element is suffering from a step mismatch, the user agent must round the element's value to the nearest number for which the element would not suffer from a step mismatch, and which is greater than or equal to the minimum, and, if the maximum is not less than the minimum, which is less than or equal to the maximum.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list