[Webkit-unassigned] [Bug 36253] First cut at SheriffBot

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36253


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50978|review?                     |review-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2010-03-17 17:43:02 PST ---
(From update of attachment 50978)
I think IRC connection should be explicit.  It's "dangerous".  It should just
return None until someone has explicitly connected.

Or you coudl have an ensure_irc_connected() method, which makes it clear that
it does work.  "irc()" could leave me in some sort of false impression that it
doesn't do any work, or certainly doesn't connect me to anything.

I think if we have some explicit connect method it should take a
username/host/channel, as whoever is calling it will have that information.

I worry that the name "finalize" is overloaded.  Maybe we should have some
custom name.  I think you mentioned "command_completed()" in person.   The
default implementation could pass.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.