[Webkit-unassigned] [Bug 33520] Mapping from local to container coord space is O(N^2)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33520


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50961|review?                     |review-
               Flag|                            |




--- Comment #43 from Simon Fraser (smfr) <simon.fraser at apple.com>  2010-03-17 17:09:59 PST ---
(From update of attachment 50961)

> diff --git a/WebCore/rendering/RenderObject.h b/WebCore/rendering/RenderObject.h

> -    virtual IntRect outlineBoundsForRepaint(RenderBoxModelObject* /*repaintContainer*/) const { return IntRect(); }
> +    virtual IntRect outlineBoundsForRepaint(RenderBoxModelObject* /*repaintContainer*/, IntPoint* /*cachedOffsetToRepaintContainer*/ = 0) const { return IntRect(); }

> diff --git a/WebCore/rendering/RenderSVGModelObject.h b/WebCore/rendering/RenderSVGModelObject.h
> -    virtual IntRect outlineBoundsForRepaint(RenderBoxModelObject* repaintContainer) const;
> +    virtual IntRect outlineBoundsForRepaint(RenderBoxModelObject* repaintContainer, IntSize*) const;

IntPoint or IntSize? The signatures don't match, so something should be broken
here, and isn't getting tested.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.