[Webkit-unassigned] [Bug 36177] [Qt] Multiselect Popup - Listbox click simulation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36177





--- Comment #15 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-03-17 14:59:31 PST ---
(From update of attachment 50923)
The thing that I don't like here, is that you are making a method that
simulates click regardless of it being a multiple selection or a normal one.

This seems a bit strange to me, as these are currently two different code
paths. The question is if they should be that or if that could be refactored.

Also multi and shift are very mouse specific, and for what you are trying to
accomplish, you will never need multi nor shift, thus maybe it makes more sense
to refactor updateSelectedState into a 

updateIndex(..., int optionIndex, bool fireOnChangeNow, ...) similar to 
SelectElement::setSelectedIndex(SelectElementData, Element, optionIndex,
deselect, fireOnChangeNow, userDrivenChange); 

and have updateSelectedState call that? 

I guess updateSelectedState does more than you need, like repaints the items,
for instance in the case you "select" an item with a mouse without holding down
the keyboard keys.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.