[Webkit-unassigned] [Bug 32077] textarea grows when you type

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 17 01:46:31 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=32077





--- Comment #18 from Shinichiro Hamaji <hamaji at chromium.org>  2010-03-17 01:46:31 PST ---
(From update of attachment 50763)
Some style nitpicks for your tests.

> diff --git a/LayoutTests/fast/forms/resources/textarea-percentage-dimensions.js b/LayoutTests/fast/forms/resources/textarea-percentage-dimensions.js
> new file mode 100644

Cannot we use script-tests ?

> index 0000000..e64c9ea
> --- /dev/null
> +++ b/LayoutTests/fast/forms/resources/textarea-percentage-dimensions.js
> @@ -0,0 +1,26 @@
> +
> +if (window.layoutTestController)
> +    layoutTestController.dumpAsText();

The first line seems to be unnecessary.

> diff --git a/LayoutTests/fast/forms/textarea-percentage-dimension-height-expected.txt b/LayoutTests/fast/forms/textarea-percentage-dimension-height-expected.txt
> new file mode 100644
> index 0000000..16fa0ef
> --- /dev/null
> +++ b/LayoutTests/fast/forms/textarea-percentage-dimension-height-expected.txt
> @@ -0,0 +1,4 @@
> +
> +a
> +
> +PASS

I don't understand this issue, but if it's possible to use another message
instead of "a", it would be nicer to have more meaningful messages.

> diff --git a/WebCore/rendering/RenderObject.h b/WebCore/rendering/RenderObject.h
> index f7b460a..85a2f4b 100644
> --- a/WebCore/rendering/RenderObject.h
> +++ b/WebCore/rendering/RenderObject.h
> @@ -954,13 +954,19 @@ inline bool objectIsRelayoutBoundary(const RenderObject *obj)
>  {
>      // FIXME: In future it may be possible to broaden this condition in order to improve performance.
>      // Table cells are excluded because even when their CSS height is fixed, their height()
> -    // may depend on their contents.
> -    return obj->isTextControl()
> -        || (obj->hasOverflowClip() && !obj->style()->width().isIntrinsicOrAuto() && !obj->style()->height().isIntrinsicOrAuto() && !obj->style()->height().isPercent() && !obj->isTableCell())
> +    // may also depend on their contents.
> +    bool hasContentsDependHeight = ((obj->style()->height().isIntrinsicOrAuto() || obj->style()->height().isPercent()) 
> +                                 || (obj->style()->minHeight().isIntrinsicOrAuto() || obj->style()->minHeight().isPercent())
> +                                 || (obj->style()->maxHeight().isIntrinsicOrAuto() || obj->style()->maxHeight().isPercent()));
> +
> +        ;

It seems like we can remove this line and it's not a false positive of style
checker?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list