[Webkit-unassigned] [Bug 34641] WebCore::RenderButton::styleDidChange ReadAV at NULL (6739b7fe455ecb54a6812c0866c3b47c)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34641





--- Comment #9 from Shinichiro Hamaji <hamaji at chromium.org>  2010-03-17 00:56:28 PST ---
(In reply to comment #4)
> Are there any other form controls that need to be avoided the same way?

Thanks for this nice catch! I tested a few other form controls before I
submitted the previous patch, but it turned out the coverage of my test wasn't
good enough. I found RenderMenuList has a similar member value and it actually
crashes. I added a check with isMenuList, too. Also, I added some more form
controls into my test so we might be able to avoid introducing similar issues
in future.

(In reply to comment #8)
> Is that all? :-)

Yeah, I think so. I grepped all headers in WebCore/rendering directory by
RenderText. RenderButton and RenderMenuList have RenderText* or
RenderTextFragment* as their members, and other classes don't have such
members.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.