[Webkit-unassigned] [Bug 36083] REGRESSION (r55772-r55834): Crash in JavaScriptCore RegExp code on PowerPC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36083





--- Comment #9 from Darin Adler <darin at apple.com>  2010-03-16 15:57:31 PST ---
(From update of attachment 50848)
> +// FIXME: This works around a bug in our port of pcre, that a regular expression run on the empty string
> +//        may still perform a read from the first element, and as such we need this to be a valid pointer.
> +//        No code should ever be reading from a zero length string, so this should be able to be a non-null
> +//        pointer into the zero-page.  Replace this with 'reinterpret_cast<UChar*>(static_cast<intptr_t>(1))'
> +//        once PCRE goes away.

We don't format our comments this way. The subsequent lines go under FIXME, not
indented.

Also, once space after a period.

Also, call it PCRE the first time, not pcre.

> +static UChar emptyUCharData = 0;

This can go inside the function instead out outside at file level.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.